diff options
| author | Julien Boudry <julien.boudry@gmail.com> | 2023-01-05 00:12:53 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-05 00:12:53 +0300 |
| commit | 8f7eec80d44f74c3aaa20634e938b071d95ff5c3 (patch) | |
| tree | e36ca69a575fe729d450b34b41e0fff020bf96ed | |
| parent | 2c646ed9fe2e34197e5632f71bce4aa59cdbcc4d (diff) | |
[PHP] Enable Mbstring (#371)
Mbstring is such a popular PHP extension that it is used everywhere and most libraries don't work without it. It can be compiled directly with PHP.
The official Docker images of PHP include it.
| -rw-r--r-- | src/php/devcontainer-feature.json | 2 | ||||
| -rwxr-xr-x | src/php/install.sh | 2 | ||||
| -rwxr-xr-x | test/php/test.sh | 1 |
3 files changed, 3 insertions, 2 deletions
diff --git a/src/php/devcontainer-feature.json b/src/php/devcontainer-feature.json index bad9878..edf56eb 100644 --- a/src/php/devcontainer-feature.json +++ b/src/php/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "php", - "version": "1.0.9", + "version": "1.0.10", "name": "PHP", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/php", "options": { diff --git a/src/php/install.sh b/src/php/install.sh index 381bec2..4d0b2ea 100755 --- a/src/php/install.sh +++ b/src/php/install.sh @@ -169,7 +169,7 @@ install_php() { VERSION_CONFIG="--with-pear" fi - ./configure --prefix="${PHP_INSTALL_DIR}" --with-config-file-path="$PHP_INI_DIR" --with-config-file-scan-dir="$CONF_DIR" --enable-option-checking=fatal --with-curl --with-libedit --with-openssl --with-zlib --with-password-argon2 --with-sodium=shared "$VERSION_CONFIG" EXTENSION_DIR="$PHP_EXT_DIR"; + ./configure --prefix="${PHP_INSTALL_DIR}" --with-config-file-path="$PHP_INI_DIR" --with-config-file-scan-dir="$CONF_DIR" --enable-option-checking=fatal --with-curl --with-libedit --enable-mbstring --with-openssl --with-zlib --with-password-argon2 --with-sodium=shared "$VERSION_CONFIG" EXTENSION_DIR="$PHP_EXT_DIR"; make -j "$(nproc)" find -type f -name '*.a' -delete diff --git a/test/php/test.sh b/test/php/test.sh index 3e4e722..0f49c1a 100755 --- a/test/php/test.sh +++ b/test/php/test.sh @@ -6,6 +6,7 @@ set -e source dev-container-features-test-lib check "PHP version" php --version +check "Mbstring loaded" php -r "extension_loaded('mbstring') || throw new Error('Extension Mbstring is not loaded');" check "Composer version" composer --version # Report result |