aboutsummaryrefslogtreecommitdiff
path: root/src/github-cli
diff options
context:
space:
mode:
authorJosh Spicer <joshspicer@github.com>2022-06-03 17:46:25 +0300
committerGitHub <noreply@github.com>2022-06-03 17:46:25 +0300
commitc12a205ab8e195541acfe0cb654b4888e16ea05c (patch)
treea1a45ac7dec9f31fa62972a65414b6d6fd1fd60d /src/github-cli
parent283b8e1f8f5dec9e54199c107e772ce56683769e (diff)
Pass options via environment variables (#39)
* up to docker-in-docker converted * first pass at the rest of the features (and bash linting and updated CLI * move shell linter to own file * rename feature.json -> devcontainer-feature.json * continue on error * continue on error in right spot * formatting * fix AZ_VERSION * update python * restore variable name * update linter actions, fix dind/dfd/desktop scripts, add test-scenaerios * add tree because I like tree * glob for shell linter * fix test-scenarios * shell linter * more shell helper
Diffstat (limited to 'src/github-cli')
-rw-r--r--src/github-cli/devcontainer-feature.json (renamed from src/github-cli/feature.json)5
-rw-r--r--src/github-cli/install.sh4
2 files changed, 5 insertions, 4 deletions
diff --git a/src/github-cli/feature.json b/src/github-cli/devcontainer-feature.json
index 9a00923..a99634c 100644
--- a/src/github-cli/feature.json
+++ b/src/github-cli/devcontainer-feature.json
@@ -4,7 +4,10 @@
"options": {
"version": {
"type": "string",
- "proposals": ["latest", "none"],
+ "proposals": [
+ "latest",
+ "none"
+ ],
"default": "latest",
"description": "Select version of the GitHub CLI, if not latest."
}
diff --git a/src/github-cli/install.sh b/src/github-cli/install.sh
index 01ad4d4..4fea41b 100644
--- a/src/github-cli/install.sh
+++ b/src/github-cli/install.sh
@@ -6,10 +6,8 @@
#
# Docs: https://github.com/microsoft/vscode-dev-containers/blob/main/script-library/docs/github.md
# Maintainer: The VS Code and Codespaces Teams
-#
-# Syntax: ./github-debian.sh [version]
-CLI_VERSION=${1:-"latest"}
+CLI_VERSION=${VERSION:-"latest"}
GITHUB_CLI_ARCHIVE_GPG_KEY=C99B11DEB97541F0
GPG_KEY_SERVERS="keyserver hkp://keyserver.ubuntu.com:80