diff options
| author | Samruddhi Khandale <skhandale@microsoft.com> | 2022-12-02 20:48:04 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-02 20:48:04 +0300 |
| commit | 7a47fbff000bff65bec9fa4687eed87cc0bc39c3 (patch) | |
| tree | 54b61ea9f66113bbdbd7536814607a1bf8bbea07 /src/node | |
| parent | 46dfa11ecd3c507187eebbd6784c09d736737255 (diff) | |
Node: Fix regression - Installing in ubuntu 18.04 (#319)
Node: Fix regression https://github.com/devcontainers/features/issues/317
Diffstat (limited to 'src/node')
| -rw-r--r-- | src/node/devcontainer-feature.json | 2 | ||||
| -rwxr-xr-x | src/node/install.sh | 6 |
2 files changed, 5 insertions, 3 deletions
diff --git a/src/node/devcontainer-feature.json b/src/node/devcontainer-feature.json index 3abfb04..216f29b 100644 --- a/src/node/devcontainer-feature.json +++ b/src/node/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "node", - "version": "1.1.3", + "version": "1.1.4", "name": "Node.js (via nvm) and yarn", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/node", "description": "Installs Node.js, nvm, yarn, and needed dependencies.", diff --git a/src/node/install.sh b/src/node/install.sh index 9b027d8..4c02c95 100755 --- a/src/node/install.sh +++ b/src/node/install.sh @@ -83,8 +83,10 @@ export DEBIAN_FRONTEND=noninteractive . /etc/os-release if [[ "bionic" = *"${VERSION_CODENAME}"* ]]; then - echo "(!) Unsupported distribution version '${VERSION_CODENAME}'. Details: https://github.com/nodejs/node/issues/42351#issuecomment-1068424442" - exit 1 + if [[ "${NODE_VERSION}" =~ "18" ]] || [[ "${NODE_VERSION}" = "lts" ]]; then + echo "(!) Unsupported distribution version '${VERSION_CODENAME}' for Node 18. Details: https://github.com/nodejs/node/issues/42351#issuecomment-1068424442" + exit 1 + fi fi # Install dependencies |