From 2af02c198adabacff30c400b0bfcad972ce5abcc Mon Sep 17 00:00:00 2001 From: Samruddhi Khandale Date: Fri, 16 Dec 2022 16:08:37 -0800 Subject: Git - Bug Fix: Feature fails with "ppa:false" for "buster" & "bullseye" (#340) --- src/git/devcontainer-feature.json | 2 +- src/git/install.sh | 4 ++-- test/git/install_git_from_src_bullseye.sh | 16 ++++++++++++++++ test/git/install_git_from_src_buster.sh | 16 ++++++++++++++++ test/git/scenarios.json | 18 ++++++++++++++++++ 5 files changed, 53 insertions(+), 3 deletions(-) create mode 100644 test/git/install_git_from_src_bullseye.sh create mode 100644 test/git/install_git_from_src_buster.sh diff --git a/src/git/devcontainer-feature.json b/src/git/devcontainer-feature.json index bc57675..c68d69d 100644 --- a/src/git/devcontainer-feature.json +++ b/src/git/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "git", - "version": "1.1.1", + "version": "1.1.2", "name": "Git (from source)", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/git", "description": "Install an up-to-date version of Git, built from source as needed. Useful for when you want the latest and greatest features. Auto-detects latest stable version and installs needed dependencies.", diff --git a/src/git/install.sh b/src/git/install.sh index 2463cc9..24e08e8 100755 --- a/src/git/install.sh +++ b/src/git/install.sh @@ -149,9 +149,9 @@ fi check_packages libpcre2-dev -if [ "${VERSION_CODENAME}" = "focal" ]; then +if [ "${VERSION_CODENAME}" = "focal" ] || [ "${VERSION_CODENAME}" = "bullseye" ]; then check_packages libpcre2-posix2 -elif [ "${VERSION_CODENAME}" = "bionic" ]; then +elif [ "${VERSION_CODENAME}" = "bionic" ] || [ "${VERSION_CODENAME}" = "buster" ]; then check_packages libpcre2-posix0 else check_packages libpcre2-posix3 diff --git a/test/git/install_git_from_src_bullseye.sh b/test/git/install_git_from_src_bullseye.sh new file mode 100644 index 0000000..4bdcf30 --- /dev/null +++ b/test/git/install_git_from_src_bullseye.sh @@ -0,0 +1,16 @@ +#!/bin/bash + +set -e + +# Optional: Import test library +source dev-container-features-test-lib + +check "version" git --version +check "gettext" dpkg-query -l gettext + +cd /tmp && git clone https://github.com/devcontainers/feature-starter.git +cd feature-starter +check "perl" bash -c "git -c grep.patternType=perl grep -q 'a.+b'" + +# Report result +reportResults diff --git a/test/git/install_git_from_src_buster.sh b/test/git/install_git_from_src_buster.sh new file mode 100644 index 0000000..4bdcf30 --- /dev/null +++ b/test/git/install_git_from_src_buster.sh @@ -0,0 +1,16 @@ +#!/bin/bash + +set -e + +# Optional: Import test library +source dev-container-features-test-lib + +check "version" git --version +check "gettext" dpkg-query -l gettext + +cd /tmp && git clone https://github.com/devcontainers/feature-starter.git +cd feature-starter +check "perl" bash -c "git -c grep.patternType=perl grep -q 'a.+b'" + +# Report result +reportResults diff --git a/test/git/scenarios.json b/test/git/scenarios.json index 90aa7e3..22af7a8 100644 --- a/test/git/scenarios.json +++ b/test/git/scenarios.json @@ -25,5 +25,23 @@ "ppa": "false" } } + }, + "install_git_from_src_bullseye": { + "image": "debian:bullseye", + "features": { + "git": { + "version": "latest", + "ppa": "false" + } + } + }, + "install_git_from_src_buster": { + "image": "debian:buster", + "features": { + "git": { + "version": "latest", + "ppa": "false" + } + } } } -- cgit v1.2.3