From e00724a0c6d4c4f8fab166e065d2b00c7357514b Mon Sep 17 00:00:00 2001 From: JP Ungaretti <19893438+jungaretti@users.noreply.github.com> Date: Mon, 14 Nov 2022 11:46:13 -0800 Subject: Add git extension for JupyterLab to Python feature (#286) * Add git extension * Bump version --- src/python/devcontainer-feature.json | 2 +- src/python/install.sh | 1 + test/python/install_additional_jupyterlab.sh | 3 +++ test/python/install_jupyterlab.sh | 3 +++ 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/python/devcontainer-feature.json b/src/python/devcontainer-feature.json index d6fa9bc..c1bcdc6 100644 --- a/src/python/devcontainer-feature.json +++ b/src/python/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "python", - "version": "1.0.12", + "version": "1.0.13", "name": "Python", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/python", "description": "Installs the provided version of Python, as well as PIPX, and other common Python utilities. JupyterLab is conditionally installed with the python feature. Note: May require source code compilation.", diff --git a/src/python/install.sh b/src/python/install.sh index e54387e..93d9cce 100755 --- a/src/python/install.sh +++ b/src/python/install.sh @@ -465,6 +465,7 @@ fi # Install JupyterLab if needed if [ "${INSTALL_JUPYTERLAB}" = "true" ]; then install_user_package jupyterlab + install_user_package jupyterlab-git # Configure JupyterLab if needed if [ -n "${CONFIGURE_JUPYTERLAB_ALLOW_ORIGIN}" ]; then diff --git a/test/python/install_additional_jupyterlab.sh b/test/python/install_additional_jupyterlab.sh index d48bb46..a5658f0 100755 --- a/test/python/install_additional_jupyterlab.sh +++ b/test/python/install_additional_jupyterlab.sh @@ -16,6 +16,9 @@ check "version" jupyter lab --version packages="$(python3 -m pip list)" check "location" grep jupyter <<< "$packages" +# Check for git extension +check "jupyterlab-git" grep jupyterlab-git <<< "$packages" + # Check for correct JupyterLab configuration check "config" grep ".*.allow_origin = '*'" /home/vscode/.jupyter/jupyter_server_config.py diff --git a/test/python/install_jupyterlab.sh b/test/python/install_jupyterlab.sh index d48bb46..a5658f0 100755 --- a/test/python/install_jupyterlab.sh +++ b/test/python/install_jupyterlab.sh @@ -16,6 +16,9 @@ check "version" jupyter lab --version packages="$(python3 -m pip list)" check "location" grep jupyter <<< "$packages" +# Check for git extension +check "jupyterlab-git" grep jupyterlab-git <<< "$packages" + # Check for correct JupyterLab configuration check "config" grep ".*.allow_origin = '*'" /home/vscode/.jupyter/jupyter_server_config.py -- cgit v1.2.3