From 9e75db9a1dbcc245f94707c0917470143c17595b Mon Sep 17 00:00:00 2001
From: Shikanime Deva <shikalegend@gmail.com>
Date: Thu, 10 Aug 2023 01:20:27 +0200
Subject: Avoid unexpected shell expansion (#645)

* Avoid unexpected shell expansion

* Add install Node with ZSH as default test

* Fix LTS only work on >bionic

* Bump Node feature version

* Remove huge universal image on scenarios
---
 test/node/scenarios.json | 20 +++++++++++---------
 test/node/zsh_default.sh | 12 ++++++++++++
 2 files changed, 23 insertions(+), 9 deletions(-)
 create mode 100755 test/node/zsh_default.sh

(limited to 'test')

diff --git a/test/node/scenarios.json b/test/node/scenarios.json
index 6112a6e..5524f5c 100644
--- a/test/node/scenarios.json
+++ b/test/node/scenarios.json
@@ -17,21 +17,23 @@
             }
         }
     },
-    "version_none": {
-        "image": "mcr.microsoft.com/devcontainers/base",
-        "remoteUser": "vscode",
+    "zsh_default": {
+        "image": "mcr.microsoft.com/devcontainers/base:ubuntu",
         "features": {
             "node": {
-                "version": "none"
+                "version": "lts"
+            },
+            "common-utils": {
+                "configureZshAsDefaultShell": true
             }
         }
     },
-    "install_node_on_universal_image": {
-        "image": "mcr.microsoft.com/devcontainers/universal",
-        "remoteUser": "codespace",
+    "version_none": {
+        "image": "mcr.microsoft.com/devcontainers/base",
+        "remoteUser": "vscode",
         "features": {
             "node": {
-                "version": "19.1.0"
+                "version": "none"
             }
         }
     },
@@ -43,4 +45,4 @@
             }
         }
     }
-}
+}
\ No newline at end of file
diff --git a/test/node/zsh_default.sh b/test/node/zsh_default.sh
new file mode 100755
index 0000000..c7c9e57
--- /dev/null
+++ b/test/node/zsh_default.sh
@@ -0,0 +1,12 @@
+#!/bin/bash
+
+set -e
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+# Definition specific tests
+check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10"
+
+# Report result
+reportResults
-- 
cgit v1.2.3